Review Request 111371: Fix duplicate targets in PythonMacros.cmake, unbreaking Ninja builds for Python-based KDE apps

[Vadim Zhukov]

> On July 4, 2013, 9:35 a.m., Luca Beltrame wrote:
> > Ship It!
> 
> Luca Beltrame wrote:
>     Please put this modification also in kdelibs master branch (in fact, put it in master so it'll get merged in next time dfaure merges master into frameworks).

Could you (or somebody else) commit it then, please? I don't have commit access.


- Vadim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111371/#review35551
-----------------------------------------------------------


On July 2, 2013, 10:58 p.m., Vadim Zhukov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111371/
> -----------------------------------------------------------
> 
> (Updated July 2, 2013, 10:58 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> Currently, PYTHON_INSTALL macro in PythonMacros.cmake creates same target "compile_python_files" for all Python modules. This somehow works for Make-based builds, but breaks when using Ninja backend for CMake. CMake itself says that it does not guarantee that targets with same name will ever work.
> 
> The patch creates unique target for each python module being pre-compiled and installed.
> 
> The patch can be applied without modifications to 4.10 and 4.11, too.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/PythonMacros.cmake 95c9315 
> 
> Diff: http://git.reviewboard.kde.org/r/111371/diff/
> 
> 
> Testing
> -------
> 
> OpenBSD-CURRENT, PyKDE 4.10.4 and 4.10.5.
> 
> 
> Thanks,
> 
> Vadim Zhukov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130704/79e991bb/attachment.htm>