Review Request 111379: Fix for kio_file crash on non-utf filenames

[Róbert Szókovács]

> On July 3, 2013, 2:20 p.m., Christoph Feck wrote:
> > Is the + 1 really required? It does not hurt to be extra safe, though.

No, it's a leftover from the QT code, probably it was there for BOM. But in the usual case we overshoot the size anyway and truncate at the end, so it doesn't actually hurt.


- Róbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111379/#review35519
-----------------------------------------------------------


On July 3, 2013, 1:54 p.m., Róbert Szókovács wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111379/
> -----------------------------------------------------------
> 
> (Updated July 3, 2013, 1:54 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> Buffersize fix for the patch in #110043.
> 
> 
> This addresses bug 321870.
>     http://bugs.kde.org/show_bug.cgi?id=321870
> 
> 
> Diffs
> -----
> 
>   kdecore/localization/klocale_kde.cpp db4af81 
> 
> Diff: http://git.reviewboard.kde.org/r/111379/diff/
> 
> 
> Testing
> -------
> 
> Yes, the old code works with strings that has only one non-UTF-non-ASCII character and crashes if there is more. The patched version allocates the correct amount of buffer.
> 
> 
> Thanks,
> 
> Róbert Szókovács
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130703/d090db96/attachment.htm>