Review Request 111370: system_tray: initialize uninitialized members
Andreas Hartmetz
ahartmetz at gmail.com
Wed Jul 3 11:50:16 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111370/#review35500
-----------------------------------------------------------
plasma/generic/applets/systemtray/ui/widgetitem.cpp
<http://git.reviewboard.kde.org/r/111370/#comment26060>
Two style issues: put the m_applet initialization on a new line (with the comma on the previous line), and use 0, not NULL.
- Andreas Hartmetz
On July 2, 2013, 6:15 p.m., Jiri Slaby wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111370/
> -----------------------------------------------------------
>
> (Updated July 2, 2013, 6:15 p.m.)
>
>
> Review request for kde-workspace and Kai Uwe Broulik.
>
>
> Description
> -------
>
> A member in WidgetItem is used unitialized. Fix this.
>
> See https://bugs.kde.org/show_bug.cgi?id=321828
>
>
> Diffs
> -----
>
> plasma/generic/applets/systemtray/ui/widgetitem.cpp 1f922c921c0f3763e8ffeb4466fbffb527fca2f2
>
> Diff: http://git.reviewboard.kde.org/r/111370/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jiri Slaby
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130703/1f480fa7/attachment.htm>
More information about the kde-core-devel
mailing list