Review Request 111335: Fix for one of the oldest KIO bugs: multiple dialogs when KIO encounters SSL errors

[Andreas Hartmetz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111335/#review35497
-----------------------------------------------------------



kio/kio/scheduler.cpp
<http://git.reviewboard.kde.org/r/111335/#comment26051>

    Just return a QString. With the pointer you have more verbosity in the caller, and the state of key is unclear after the call because it may or may not have been changed.
    
    The Request could be passed as a const reference here, so why not do that?
    
    Would it make sense to have this method in the Request class as
    QString key() const ?



kio/kio/scheduler.cpp
<http://git.reviewboard.kde.org/r/111335/#comment26055>

    braces



kio/kio/scheduler.cpp
<http://git.reviewboard.kde.org/r/111335/#comment26043>

    kdelibs style: always use braces (even if this code is copied from somewhere else)



kio/kio/scheduler.cpp
<http://git.reviewboard.kde.org/r/111335/#comment26050>

    What the heck did I do there? :O
    (/*H4X*/ is something I use to mark temporary hacks)



kio/kio/scheduler.cpp
<http://git.reviewboard.kde.org/r/111335/#comment26046>

    m_cachedResults is never cleaned - I admit that this is not much different from the SSL config file never losing exceptions stored there.
    
    So I suggest cleaning m_cachedResults, but the current patch is not significantly worse than what we have.
    
    This is related to making an SSL exception for "current sessions only", which is actually for 30 minutes. Unless you also make it really for current sessions, after 30 minutes would be a good time to clear such entries.



kio/kio/scheduler.cpp
<http://git.reviewboard.kde.org/r/111335/#comment26048>

    Should be easier to just make it a child of the public class.



kio/kio/slaveinterface.cpp
<http://git.reviewboard.kde.org/r/111335/#comment26049>

    Early return for less nesting


- Andreas Hartmetz


On July 1, 2013, 5:10 a.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111335/
> -----------------------------------------------------------
> 
> (Updated July 1, 2013, 5:10 a.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> The attached patch addresses one of the oldest bugs in KIO. Due to the muti-process nature of KIO, if any of the ioslaves encounter something that requires user input, the user might end up getting prompted multiple times. The best example of this is SSL error warnings sent to the client by kio_http. The patch completely resolves this problem using the same approach as kpasswdserver, but without the need for an additional kded process.
> 
> 
> This addresses bugs 154100 and 265228.
>     http://bugs.kde.org/show_bug.cgi?id=154100
>     http://bugs.kde.org/show_bug.cgi?id=265228
> 
> 
> Diffs
> -----
> 
>   kio/kio/scheduler.h 04edb40 
>   kio/kio/scheduler.cpp 802f8b8 
>   kio/kio/scheduler_p.h d68f645 
>   kio/kio/slaveinterface.h 4bfcec8 
>   kio/kio/slaveinterface.cpp aa0fc44 
>   kio/kio/slaveinterface_p.h e31ec5e 
> 
> Diff: http://git.reviewboard.kde.org/r/111335/diff/
> 
> 
> Testing
> -------
> 
> Visit a site that throws up SSL warnings and causes KIO to show more than one error dialog.
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130703/73bbb48f/attachment.htm>