Review Request 111342: make kinfocenter compile on non x11 systems and Windows

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111342/#review35374
-----------------------------------------------------------


from my side it looks OK, though I won't give a ship-it. This is a decision to the kinfocenter developers whether they are fine with the ifdefs.

- Martin Gräßlin


On July 1, 2013, 3:14 p.m., Patrick von Reth wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111342/
> -----------------------------------------------------------
> 
> (Updated July 1, 2013, 3:14 p.m.)
> 
> 
> Review request for kde-workspace and kwin.
> 
> 
> Description
> -------
> 
> make kinfocenter compile on non x11 systems and Windows
> Kinfocenter is quite useful to test a solid backend
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 57cd82c56539b93fafe7866a259c155eebcc86a0 
>   kinfocenter/Modules/CMakeLists.txt 0a87eb48d97df2e0224819225ba0af6bf0d93f39 
>   kinfocenter/Modules/base/os_base.h f09202d9d0c592238735dc1b2d5041a921358adb 
>   kinfocenter/Modules/devinfo/soldevicetypes.cpp d3387d972b14368e9fa2b5ad1f97d5210d2beb01 
> 
> Diff: http://git.reviewboard.kde.org/r/111342/diff/
> 
> 
> Testing
> -------
> 
> windows
> 
> 
> Thanks,
> 
> Patrick von Reth
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130701/176b0bfb/attachment.htm>