Review Request 111335: Fix for one of the oldest KIO bugs: multiple dialogs when KIO encounters SSL errors

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111335/
-----------------------------------------------------------

Review request for kdelibs.


Description
-------

The attach patch address one of the oldest bugs of in KIO. Due to the muti-process nature of KIO, the user gets prompted multiple times if any of the ioslaves encounter something that requires user input. The best example of this is the HTTP dialog sending SSL error warnings to the client. 

The fix address all issues related to such problems and manages the dialogs in much the same way as kpasswdserver minus the need for a kded module.


This addresses bug 265228.
    http://bugs.kde.org/show_bug.cgi?id=265228


Diffs
-----

  kio/kio/scheduler.h 04edb40 
  kio/kio/scheduler.cpp 802f8b8 
  kio/kio/scheduler_p.h d68f645 
  kio/kio/slaveinterface.h 4bfcec8 
  kio/kio/slaveinterface.cpp aa0fc44 
  kio/kio/slaveinterface_p.h e31ec5e 

Diff: http://git.reviewboard.kde.org/r/111335/diff/


Testing
-------

- Visit a site that throws up SSL warnings and causes KIO to show more than one error dialog.
- Apply the patch and do the same.


Thanks,

Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130701/ba49f44c/attachment.htm>