Review Request 106861: Add pkgconfig hints to FindSamba.cmake

[Rex Dieter]

> On Jan. 31, 2013, 5:47 p.m., Alexander Neundorf wrote:
> > Is setting CMAKE_PREFIX_PATH not enough to make it work ?
> > Where is the non-standard location which needs to be searched in your case ?

Without this, headers in /usr/include/samba-4.0 are not found (and I figured it better long-term to use pkg-config hints rather than adding another hard-coded hint)


- Rex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106861/#review26461
-----------------------------------------------------------


On Jan. 31, 2013, 4:58 p.m., Rex Dieter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106861/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2013, 4:58 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> Add pkgconfig hints to FindSamba.cmake, helps find samba4 libs on non-standard-ish locations.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindSamba.cmake 16522c6 
> 
> Diff: http://git.reviewboard.kde.org/r/106861/diff/
> 
> 
> Testing
> -------
> 
> Tested on fedora 18 against samba-4.0-rc2
> 
> 
> Thanks,
> 
> Rex Dieter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130131/43a2a93b/attachment.htm>