Review Request 107409: [KMenuEdit] Ability to sort elements

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107409/#review26215
-----------------------------------------------------------


Ok, leave the int for the signalmapper there, it's not that bad


kmenuedit/kmenuedit.cpp
<http://git.reviewboard.kde.org/r/107409/#comment19929>

    



kmenuedit/treeview.h
<http://git.reviewboard.kde.org/r/107409/#comment19928>

    this should be const



kmenuedit/treeview.cpp
<http://git.reviewboard.kde.org/r/107409/#comment19930>

    This brackets in the function line don't follow the style of the rest of the file, i'd prefer if you preserved the file style if possible



kmenuedit/treeview.cpp
<http://git.reviewboard.kde.org/r/107409/#comment19932>

    I think that if no description is found in either of the items you should defer to sorting by name, Otherwise I get a "random" sort that is pretty weird when sorting a folder in which no item has description


- Albert Astals Cid


On Jan. 19, 2013, 10:09 p.m., Julien Borderie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107409/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2013, 10:09 p.m.)
> 
> 
> Review request for kde-workspace and Albert Astals Cid.
> 
> 
> Description
> -------
> 
> Hi,
> 
> This patch adds 2 actions to sort items in KMenuEdit (by name or description) :
> - sort sub-elements for the current selection.
> - sort all elements.
> 
> Particularities :
> - It respects separator elements to avoid mixing elements groups together.
> - Actions are available in the main menu, toolbar and contextual menu.
> - Once saved, changes also visible in the K menu.
> - Recursive sort.
> - Selection sorting is disabled if the selection is empty or is not a menu.
> 
> Thank you for your review.
> 
> 
> This addresses bug 108419.
>     http://bugs.kde.org/show_bug.cgi?id=108419
> 
> 
> Diffs
> -----
> 
>   kmenuedit/kmenuedit.cpp 6a0506b 
>   kmenuedit/kmenueditui.rc 273847d 
>   kmenuedit/main.cpp 65efdf9 
>   kmenuedit/treeview.h 0284584 
>   kmenuedit/treeview.cpp b144b1c 
> 
> Diff: http://git.reviewboard.kde.org/r/107409/diff/
> 
> 
> Testing
> -------
> 
> If started KMenuEdit does not make part of the running KDE version, these following test cases require to make a kbuildsycoca4 to be visible in the current K menu.
> 
> 1) Sort element by name
> - Select an element
> - Choose "sort by name" --> item children sorted
> - Now save (and kbuildsycoca4) --> kmenu displays sorted children
> 
> 2) Sort element by description
> - Select an element
> - Choose "sort by description" --> item children sorted
> - Now save (and kbuildsycoca4) --> kmenu displays sorted children
> 
> 3) Sort all by name
> - Choose "sort all by name" --> all items sorted
> - Now save (and kbuildsycoca4) --> kmenu displays sorted items
> 
> 4) Sort all by description
> - Choose "sort all by description" --> all items sorted
> - Now save (and kbuildsycoca4) --> kmenu displays sorted items
> 
> 
> Thanks,
> 
> Julien Borderie
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130126/1cb7f7a8/attachment.htm>