Review Request 108570: This patch add support for bulk operations in systemtray applet settings.

[Sandro Andrade]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108570/
-----------------------------------------------------------

(Updated Jan. 25, 2013, 4:09 p.m.)


Review request for kde-workspace.


Changes
-------

Patch updated. Link to demo video: http://wiki.ifba.edu.br/systraybulkop.ogv
Bulk operations are shown only when some item(s) is(are) selected.
It's up to you to decide if we keep the clear shortcut icon :)
If removing it we might remove the whole bulk operation table and then use a
single QLabel+KComboBox (probably not getting aligned to item's KComboBox anymore).


Description
-------

In page 'entries', user can select/deselect a specific or all entries and then change visibility and/or reset shortcut for all of them with a single combo selection/clear button click. Individually selecting all entries causes header's checkbox to automatically be checked. After selecting all entries (individually or by clicking in header's checkbox), a single entry deselection causes header's checkbox to automatically be unchecked. General suggestions and, in particular about UI usability, are appreciated.


Diffs (updated)
-----

  plasma/generic/applets/systemtray/ui/autohide.ui 3b6efff 
  plasma/generic/applets/systemtray/ui/applet.h 0b4a869 
  plasma/generic/applets/systemtray/ui/applet.cpp 09482d7 

Diff: http://git.reviewboard.kde.org/r/108570/diff/


Testing
-------


File Attachments
----------------

Initial setup
  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/24/systemtray-bulkactions1.png
Setting all visibilities to 'Auto'
  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/24/systemtray-bulkactions2.png
All visibilities adjusted to 'Auto'
  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/24/systemtray-bulkactions3.png
Setting two specific item visibilities to 'Always Visible'
  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/24/systemtray-bulkactions4.png


Thanks,

Sandro Andrade

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130125/8df84dc2/attachment.htm>