Review Request 108570: This patch add support for bulk operations in systemtray applet settings.

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108570/#review26137
-----------------------------------------------------------


While usually we don't want to have visual elements hiding and disappearing, in this case I wonder if it would make it more evident/obvious what the bottom items are for (and remove the visual clutter when they aren't needed). Yes, that would be rather "web app like" (for lack of a better term), but it may work nicely here.

The phrase "All selected items" .. this might get rather long depending on the translation? Perhaps just i18np("1 item", "%1 items", itemCount)?

It took me a moment to realize what the [<] button was for; ah, yes, to remove all key combinations. Seeing as those can't be set all at once, does it make sense to allow them to all be reset? If it is kept, I'd recommend something more obvious, such as a button with e.g. "No shortcut" 

- Aaron J. Seigo


On Jan. 24, 2013, 4:11 p.m., Sandro Andrade wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108570/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2013, 4:11 p.m.)
> 
> 
> Review request for kde-workspace.
> 
> 
> Description
> -------
> 
> In page 'entries', user can select/deselect a specific or all entries and then change visibility and/or reset shortcut for all of them with a single combo selection/clear button click. Individually selecting all entries causes header's checkbox to automatically be checked. After selecting all entries (individually or by clicking in header's checkbox), a single entry deselection causes header's checkbox to automatically be unchecked. General suggestions and, in particular about UI usability, are appreciated.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/systemtray/ui/applet.cpp 09482d7 
>   plasma/generic/applets/systemtray/ui/autohide.ui 3b6efff 
> 
> Diff: http://git.reviewboard.kde.org/r/108570/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Initial setup
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/24/systemtray-bulkactions1.png
> Setting all visibilities to 'Auto'
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/24/systemtray-bulkactions2.png
> All visibilities adjusted to 'Auto'
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/24/systemtray-bulkactions3.png
> Setting two specific item visibilities to 'Always Visible'
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/24/systemtray-bulkactions4.png
> 
> 
> Thanks,
> 
> Sandro Andrade
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130124/193e5b9d/attachment.htm>