Review Request 108570: This patch add support for bulk operations in systemtray applet settings.

Sandro Andrade sandroandrade at kde.org
Thu Jan 24 16:04:16 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108570/
-----------------------------------------------------------

(Updated Jan. 24, 2013, 1:04 p.m.)


Review request for kde-workspace.


Changes
-------

All issues fixed (see comments below). Screenshots attached. New diff uploaded.


Description
-------

In page 'entries', user can select/deselect a specific or all entries and then change visibility and/or reset shortcut for all of them with a single combo selection/clear button click. Individually selecting all entries causes header's checkbox to automatically be checked. After selecting all entries (individually or by clicking in header's checkbox), a single entry deselection causes header's checkbox to automatically be unchecked. General suggestions and, in particular about UI usability, are appreciated.


Diffs
-----

  plasma/generic/applets/systemtray/ui/applet.h 0b4a869 
  plasma/generic/applets/systemtray/ui/applet.cpp 09482d7 
  plasma/generic/applets/systemtray/ui/autohide.ui 3b6efff 

Diff: http://git.reviewboard.kde.org/r/108570/diff/


Testing
-------


File Attachments (updated)
----------------

Initial setup
  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/24/systemtray-bulkactions1.png
Setting all visibilities to 'Auto'
  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/24/systemtray-bulkactions2.png
All visibilities adjusted to 'Auto'
  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/24/systemtray-bulkactions3.png
Setting two specific item visibilities to 'Always Visible'
  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/24/systemtray-bulkactions4.png


Thanks,

Sandro Andrade

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130124/e30ce350/attachment.htm>


More information about the kde-core-devel mailing list