Review Request 108560: Fix kconfigcompiler_test

Alexander Richardson arichardson.kde at
Tue Jan 22 21:45:14 GMT 2013

This is an automatically generated e-mail. To reply, visit:

Review request for kdelibs.

Summary (updated)

Fix kconfigcompiler_test

Description (updated)

Fix kconfigcompiler_test

It previously did not find the required files since CMake set TESTSRCDIR
wrongly. It was surrounded by quotes and lacking a trailing /

This did not cause test failures since QCOMPARE/QVERIFY was not used
directly in the test function, so it simply printed messages instead.

Diffs (updated)

  tier2/kconfig/autotests/kconfig_compiler/CMakeLists.txt 846476a6370ad41b1fbc808e2c738c85042e59a3 
  tier2/kconfig/autotests/kconfig_compiler/kconfigcompiler_test.h 1be213f5036c03a3ef9347005d5d53e6b440a4d4 
  tier2/kconfig/autotests/kconfig_compiler/kconfigcompiler_test.cpp f900aaf53de1996213c27357fee5b436ab3c4c8f 


Testing (updated)

Unit test now passes instead of printing messages and failing silently


Alexander Richardson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list