Review Request 105430: kjs: Implement html5 HTMLSelectCollectionProtoFunc::remove

Bernd Buschinski b.buschinski at googlemail.com
Tue Jan 22 03:11:47 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105430/
-----------------------------------------------------------

(Updated Jan. 22, 2013, 3:11 a.m.)


Review request for kdelibs.


Changes
-------

rebase on KDE/4.10


Description
-------

kjs: Implement html5 HTMLSelectCollectionProtoFunc::remove

with this

getElementById("mySELECT").options.remove(index)
getElementById("mySELECT").remove(index)

works as described in 
http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-interfaces.html#dom-htmloptionscollection-remove


Diffs (updated)
-----

  khtml/ecma/kjs_html.h 37980b9 
  khtml/ecma/kjs_html.cpp 9f8f6d0 

Diff: http://git.reviewboard.kde.org/r/105430/diff/


Testing
-------


Thanks,

Bernd Buschinski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130122/f4e5d965/attachment.htm>


More information about the kde-core-devel mailing list