Review Request 106671: kjs/khtml: Reuse existing html5 Audio Element instead of duplicating it
Bernd Buschinski
b.buschinski at googlemail.com
Tue Jan 22 03:11:42 GMT 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106671/
-----------------------------------------------------------
(Updated Jan. 22, 2013, 3:11 a.m.)
Review request for kdelibs.
Changes
-------
rebase on KDE/4.10
Description
-------
kjs/khtml: Reuse existing html5 Audio Element instead of duplicating it
that adds all html functionality to the javascript Audio.
Previous one just had pause/play/stop/omload/onerror and
NOTE "stop" is not even part of the HTMLAudioElement/HTMLMediaElement(.idl), so its removed now.
Diffs (updated)
-----
khtml/CMakeLists.txt 99034cc
khtml/ecma/kjs_audio.h 956d72a
khtml/ecma/kjs_audio.cpp f67cdc9
Diff: http://git.reviewboard.kde.org/r/106671/diff/
Testing
-------
Makes websites like
http://release.blackmesasource.com/?sm2-preferflash=false
and
http://9elements.com/html5demos/audio/
from the javascript point of view
not 100% as the html element is still missing some implementations
e.g. scheduleLoad and canplay event
Thanks,
Bernd Buschinski
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130122/974429d8/attachment.htm>
More information about the kde-core-devel
mailing list