Review Request 107409: [KMenuEdit] Ability to sort elements

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107409/#review25734
-----------------------------------------------------------


Thanks Julien for the patch. Please ask for help in in #kde-devel irc channel, or on an KDE developers mailing list. The diff needs to be uploaded differently.

- Christoph Feck


On Jan. 17, 2013, 6:07 p.m., Julien Borderie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107409/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2013, 6:07 p.m.)
> 
> 
> Review request for kde-workspace and Albert Astals Cid.
> 
> 
> Description
> -------
> 
> Hi,
> 
> This patch adds 2 actions to sort items in KMenuEdit (by name or description) :
> - sort sub-elements for the current selection.
> - sort all elements.
> 
> It respects separator elements to avoid mixing elements groups together.
> Actions are visible in the main menu, toolbar and contextual menu.
> 
> Thank you for your review.
> 
> 
> This addresses bug 108419.
>     http://bugs.kde.org/show_bug.cgi?id=108419
> 
> 
> Diffs
> -----
> 
>   kmenuedit/treeview.cpp f43ed1d 
> 
> Diff: http://git.reviewboard.kde.org/r/107409/diff/
> 
> 
> Testing
> -------
> 
> - Select an element and choose "sort by name".
> - Select an element and choose "sort by description".
> - Choose "sort all by name".
> - Choose "sort all by description".
> - Select an empty menu or a simple element -> selection sorting disabled.
> 
> 
> File Attachments
> ----------------
> 
> 
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/17/patch.diff
> 
> 
> Thanks,
> 
> Julien Borderie
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130117/483c7af4/attachment.htm>