Review Request 108433: [High-dpi issues] Fix color kcm list when using big fonts
Thomas Lübking
thomas.luebking at gmail.com
Wed Jan 16 10:10:35 GMT 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108433/#review25637
-----------------------------------------------------------
kcontrol/colors/colorscm.cpp
<http://git.reviewboard.kde.org/r/108433/#comment19545>
w/o having checked code it seems the view has a static row height and the last kid would by this set the game.
i'd say minHeight should be determined as qMax(minHeight, btn->sizeHint().height()) and initialized by the font height (given the font is equal for all elements, otherwise needs to be qMax'd in every row as well)
ultimately in a second pass set all row heights, while probably even setting one would be sufficient
- Thomas Lübking
On Jan. 16, 2013, 1:56 a.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108433/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2013, 1:56 a.m.)
>
>
> Review request for kde-workspace.
>
>
> Description
> -------
>
> This makes the row height of color list depend on the height of the "Varies" button.
>
> The KColorButtons on the other pages also need fixing but this should be done in KColorButton in kdelibs rather than hacking in the "Varies" thing there as well.
>
> (Not sure if I need to delete that PushButton afterwards)
>
>
> Diffs
> -----
>
> kcontrol/colors/colorscm.cpp b9b911f
>
> Diff: http://git.reviewboard.kde.org/r/108433/diff/
>
>
> Testing
> -------
>
> Yup, see screenshots.
>
>
> File Attachments
> ----------------
>
> After with normal fonts
> http://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/colornormalsize.png
> Before with huge fonts
> http://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/colorbigsizebefore.png
> After with huge fonts
> http://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/colorbigsizeafter.png
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130116/e17202ae/attachment.htm>
More information about the kde-core-devel
mailing list