Review Request 108433: [High-dpi issues] Fix color kcm list when using big fonts

Kai Uwe Broulik kde at privat.broulik.de
Wed Jan 16 00:36:28 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108433/
-----------------------------------------------------------

Review request for kde-workspace.


Description
-------

This makes the row height of color list depend on the height of the "Varies" button.

The KColorButtons on the other pages also need fixing but this should be done in KColorButton in kdelibs rather than hacking in the "Varies" thing there as well.

(Not sure if I need to delete that PushButton afterwards)


Diffs
-----

  kcontrol/colors/colorscm.cpp b9b911f 

Diff: http://git.reviewboard.kde.org/r/108433/diff/


Testing
-------

Yup, see screenshots.


File Attachments
----------------

After with normal fonts
  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/colornormalsize.png
Before with huge fonts
  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/colorbigsizebefore.png
After with huge fonts
  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/colorbigsizeafter.png


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130116/4b00553d/attachment.htm>


More information about the kde-core-devel mailing list