Review Request 108418: use system to suspend and hibernate in powerdevil

Dario Freddi drf at kde.org
Tue Jan 15 00:05:29 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108418/#review25545
-----------------------------------------------------------


A similar patch has been submitted today as #108407. I'll have a look at this as well, but ideally you should probably talk to Lukas about it.

- Dario Freddi


On Jan. 15, 2013, midnight, Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108418/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2013, midnight)
> 
> 
> Review request for kde-workspace, Solid, Dario Freddi, and Lukáš Tinkl.
> 
> 
> Description
> -------
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=859227
> 
> patch is straight forward, use systemd to suspend and hibernate.
> 
> Add new xml since this patch is shared, and looks like it will always built with systemd so no more check is required.
> 
> UPower is still being notified from systemd so Resuming signal can still be used.
> 
> 
> Diffs
> -----
> 
>   powerdevil/daemon/BackendConfig.cmake 5dbe6f6 
>   powerdevil/daemon/CMakeLists.txt 04f3050 
>   powerdevil/daemon/backends/upower/powerdevilupowerbackend.h ba942bd 
>   powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp 97a409b 
>   powerdevil/daemon/backends/upower/upowersuspendjob.h bbe2f45 
>   powerdevil/daemon/backends/upower/upowersuspendjob.cpp fa64ab0 
>   powerdevil/daemon/org.freedesktop.login1.Manager.xml PRE-CREATION 
>   powerdevil/daemon/powerdevilpolicyagent.cpp 1451c5e 
> 
> Diff: http://git.reviewboard.kde.org/r/108418/diff/
> 
> 
> Testing
> -------
> 
> I don't have swap so only suspend is tested. Problem seems fixed.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130115/67b8caf9/attachment.htm>


More information about the kde-core-devel mailing list