Review Request 108367: Complete keyboard preview rework for KControl

[Manuel Tortosa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108367/
-----------------------------------------------------------

(Updated Jan. 12, 2013, 5:11 p.m.)


Review request for kde-workspace.


Description
-------

I am working in a keyboard preview widget, based on kcontrol's one, for the Chakra Project's installer. If you are interested i can create a patch so it may replace the KDE one.

This one is 768x292 (the one in kcontrol is 1300+ wide, not suitable for lower resolutions), and it is almost done (i need to center the Ctrl, Alt and ALtGr texts using QTextMetric or whatever and create the Tab key).

If you are interested i can create the patch, the relevant files are kbpreviewframe.cpp+h, the current code (need clean, etc) it is located here:

http://gitorious.org/chakra/tribe/blobs/info/src/widgets/kbpreview/kbpreviewframe.cpp
http://gitorious.org/chakra/tribe/blobs/info/src/widgets/kbpreview/kbpreviewframe.h

The change is kinda big and it is my first attempt to create something with Qt so i prefer to wait some ideas before actually create the relevant patch.


Diffs
-----


Diff: http://git.reviewboard.kde.org/r/108367/diff/


Testing
-------

Basically i have tested it in our installer and works.


File Attachments (updated)
----------------

Preview2
  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/12/keyboard_preview_1.jpg
before
  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/12/before.png
after
  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/12/after.jpg


Thanks,

Manuel Tortosa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130112/52ca2380/attachment.htm>