Review Request: fix 234407 - set minimum width for system settings icon view

Xuetian Weng wengxt at
Thu Jan 10 20:48:41 GMT 2013

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 10, 2013, 8:48 p.m.)

Review request for kde-workspace, Ben Cooksley, Thomas L├╝bking, Chao Feng, and Yichao Yu.


add spanish screenshot before apply the patch.


Set minimum width for system settings icon view item depending on font. Since KFileItemDelegate doesn't provides setMinimumSize, we make a sub-class that can have a minimumSize. (Maybe should be add to kdelibs in the future?)

This fontHeight * 6 heuristic value works for all languages. CJK character is usually square (width = height) so this roughly means 6 CJK character, and 12 latin letter (height = width * 2), which will always look good.

To fengchao, I'm sorry if you feel I steal your job.. but I can't stop myself since I think I can fix it in 10 minutes..

This addresses bug 234407.


  systemsettings/icons/CMakeLists.txt 0830dd7 
  systemsettings/icons/FileItemDelegate.h PRE-CREATION 
  systemsettings/icons/FileItemDelegate.cpp PRE-CREATION 
  systemsettings/icons/IconMode.cpp 37cfc4b 



see screenshot.

Screenshots (updated)

english after change
chinese after change
chinese before change
spanish after change
spanish before change


Xuetian Weng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list