Review Request: Fix bug 234407 - systemsettings iconview wordwrapping cause narrow icon in zhcn locale

[Ben Cooksley]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108285/#review25038
-----------------------------------------------------------


Code itself looks okay, see issue below though.


systemsettings/icons/IconMode.cpp
<http://git.reviewboard.kde.org/r/108285/#comment19173>

    Not sure I like the idea of a hardcoded list of languages... is there a better way of determining if a language is CJK?


- Ben Cooksley


On Jan. 9, 2013, 4:33 a.m., Chao Feng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108285/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2013, 4:33 a.m.)
> 
> 
> Review request for kde-workspace.
> 
> 
> Description
> -------
> 
> CJK languages do not use space as words seperator. 
> 
> And a CJK translation of the text in Systemsettings are very short. A single line is enough for them.
> 
> 
> This addresses bug 234407.
>     http://bugs.kde.org/show_bug.cgi?id=234407
> 
> 
> Diffs
> -----
> 
>   systemsettings/icons/IconMode.cpp 37cfc4bed42e4d05fc4c01008f8ca2c63b287b5e 
> 
> Diff: http://git.reviewboard.kde.org/r/108285/diff/
> 
> 
> Testing
> -------
> 
> 1. Apply patch
> 2. Systemsetting show ok on CJK
> 
> 
> Thanks,
> 
> Chao Feng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130109/c18d7e19/attachment.htm>