Review Request: Fix KWindowSystem::compositingChanged signal

[Thomas Lübking]

> On Jan. 9, 2013, 1:38 a.m., Xuetian Weng wrote:
> > kdeui/windowmanagement/kwindowsystem_x11.cpp, line 168
> > <http://git.reviewboard.kde.org/r/107983/diff/4/?file=106081#file106081line168>
> >
> >     I don't quite get why this part is required. Since KWindowSystem already calls SelectSelectionInput in constructor, just use the above one and do window == winId and event->selection == net_wm_cm is enough.

It's required because it is the central aspect about the workaround.
The problem is that the code as present uses the XFixesSelectSelection to get the event on winId but because of the compressing behavior in Qt, it's usually lost. That's the root of bug #179042.


> On Jan. 9, 2013, 1:38 a.m., Xuetian Weng wrote:
> > kdeui/windowmanagement/kwindowsystem_x11.cpp, line 158
> > <http://git.reviewboard.kde.org/r/107983/diff/4/?file=106081#file106081line158>
> >
> >     I thought you should check event->selection == net_wm_cm here, no?

No, but it certainly would not harm below.
winId only select that selection anyway, it should not get others.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107983/#review25025
-----------------------------------------------------------


On Jan. 9, 2013, 12:52 a.m., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107983/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2013, 12:52 a.m.)
> 
> 
> Review request for kdelibs, kwin, Plasma, Aaron J. Seigo, Marco Martin, Martin Gräßlin, and Fredrik Höglund.
> 
> 
> Description
> -------
> 
> It works fine here (tested so far KWindowSystem signal, KSelectionWatcher only with kwin) with kwin (shift+alt+f12), xcompmgr, compiz & "metacity -c" and e17.
> Didn't try xfce nor mutter.
> 
> Technically:
> I do not at all understand why KWindowSystem is *not* watching the root window - KSelectionOwner for one is sending events to the root and this also seems the case for all other WMs (at least everything now starts to cause the signal to be emitted)
> 
> The KSelectionWatcher failure seems to be kwin specific (wrote me a cleaner testcase), there'll be some X11 event processing on top that eats away the client messages.
> So this one can be scratched from the patch, the KWindowSystem issue remains.
> 
> 
> This addresses bug 179042.
>     http://bugs.kde.org/show_bug.cgi?id=179042
> 
> 
> Diffs
> -----
> 
>   kdeui/windowmanagement/kwindowsystem_x11.cpp f9b3cc1 
> 
> Diff: http://git.reviewboard.kde.org/r/107983/diff/
> 
> 
> Testing
> -------
> 
> see summary
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130109/e9047767/attachment.htm>