Review Request: KHTML, imload: Fix wrong version of last line of scaled tile

[Albert Astals Cid]

> On Jan. 7, 2013, 6:30 p.m., Albert Astals Cid wrote:
> > Evil: do you think you could provide a test? Seems like if you already have an image that files, maybe it wouldn't be that hard?
> 
> Aurélien Gâteau wrote:
>     Can be done, but I don't know where to put such tests: there is khtml/test/ but this contains only a few html files, images and a README which says not to add anything there. There is also khtml/tests/ which contains one unittest: khtmlparttest, but this is about testing instantiation of the KHTMLPart class. Is there a set of unit tests to check KHTML rendering?

I was thinking that maybe you could just throw up a quick test that just called scaleLoop32bit and checked the resulting image pixels where correct, i'm not asking for anything fancy, but as said, it's just a wish, it's not like any of the bugs we do everywhere are unittested :D


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108246/#review24936
-----------------------------------------------------------


On Jan. 7, 2013, 6:16 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108246/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2013, 6:16 p.m.)
> 
> 
> Review request for kdelibs, Martin Tobias Holmedahl Sandsmark and Maks Orlovich.
> 
> 
> Description
> -------
> 
> Code in scaledLoop32bit() has an off-by-one error in computation of the versions index, causing some images to contain garbage on their last line. This is visible in Konqueror and Akregator intro pages.
> 
> 
> Diffs
> -----
> 
>   khtml/imload/scaledimageplane.cpp e8ab684 
> 
> Diff: http://git.reviewboard.kde.org/r/108246/diff/
> 
> 
> Testing
> -------
> 
> Tested Akregator and Konqueror about pages. Browsed a few websites with Konqueror + KHTML.
> 
> 
> Screenshots
> -----------
> 
> Konqueror, before - after
>   http://git.reviewboard.kde.org/r/108246/s/988/
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130108/9943069a/attachment.htm>