Review Request: qml based kwin shadow

[Xuetian Weng]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108243/
-----------------------------------------------------------

(Updated Jan. 7, 2013, 4:07 p.m.)


Review request for kde-workspace, kwin, Plasma, Thomas Lübking, Aaron J. Seigo, Marco Martin, and Martin Gräßlin.


Changes
-------

so how about move them into org.kde.kwin.tabbox?

BTW, desktopchangeosd uses PlasmaCore.Dialog, so it doesn't have shadow problem I think.


Description
-------

This is a different solution solve problem in https://git.reviewboard.kde.org/r/108224/

1. use qml to draw shadow in DeclarativeView.
2. set blur mask svg property in qml
3. and fix some layout problem in big icons and small icons.


Diffs (updated)
-----

  kwin/tabbox/declarative.cpp 3bdcfac 
  kwin/tabbox/qml/CMakeLists.txt d4bc863 
  kwin/tabbox/qml/IconTabBox.qml 23bb11b 
  kwin/tabbox/qml/ShadowedSvgItem.qml PRE-CREATION 
  kwin/tabbox/qml/clients/big_icons/contents/ui/main.qml 7115b7f 
  kwin/tabbox/qml/clients/compact/contents/ui/main.qml 1f6f036 
  kwin/tabbox/qml/clients/informative/contents/ui/main.qml 3a2c4a3 
  kwin/tabbox/qml/clients/present_windows/contents/ui/main.qml 14a54d3 
  kwin/tabbox/qml/clients/small_icons/contents/ui/main.qml ea09ed0 
  kwin/tabbox/qml/clients/text/contents/ui/main.qml c0def27 
  kwin/tabbox/qml/clients/thumbnails/contents/ui/main.qml efe3ebe 
  kwin/tabbox/qml/qmldir PRE-CREATION 
  kwin/tabbox/qml/tabbox.qml 4176231 

Diff: http://git.reviewboard.kde.org/r/108243/diff/


Testing
-------

all desktop tabbox is tested with Air and Slim Glow, composite and non-composite, no problem.


Thanks,

Xuetian Weng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130107/49fdcfda/attachment.htm>
-------------- next part --------------
_______________________________________________
kwin mailing list
kwin at kde.org
https://mail.kde.org/mailman/listinfo/kwin