Review Request: use Plasma::Dialog for brightness osd

[Kai Uwe Broulik]

> On Jan. 6, 2013, 3:45 p.m., Kai Uwe Broulik wrote:
> > Just applied the patch from Review 107983 and your patch resolves the issue. Would you mind if I use that code to fix KMix OSD?
> 
> Xuetian Weng wrote:
>     Well.. actually I have a review for kmix :P
>     https://git.reviewboard.kde.org/r/108223/

Haven't seen it :) Looks good from my POV but add the solid group because these are the ones responsible for PowerDevil :)


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108222/#review24840
-----------------------------------------------------------


On Jan. 6, 2013, 10:25 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108222/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2013, 10:25 p.m.)
> 
> 
> Review request for kde-workspace, Plasma and Aaron J. Seigo.
> 
> 
> Description
> -------
> 
> well, you know.. this would fix the shadow problem, and clean up code actually.
> 
> 
> Diffs
> -----
> 
>   powerdevil/daemon/brightnessosdwidget.h ef08903 
>   powerdevil/daemon/brightnessosdwidget.cpp e4cf80a 
> 
> Diff: http://git.reviewboard.kde.org/r/108222/diff/
> 
> 
> Testing
> -------
> 
> locally tested, no problem.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130106/195d5b85/attachment.htm>
-------------- next part --------------
_______________________________________________
Plasma-devel mailing list
Plasma-devel at kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel