Review Request: set brightness to zero in profile doesn't work

Xuetian Weng wengxt at gmail.com
Sun Jan 6 18:00:48 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108230/
-----------------------------------------------------------

(Updated Jan. 6, 2013, 6 p.m.)


Review request for kde-workspace and Kai Uwe Broulik.


Description
-------

fix is trivial, since -1 is the invalid value in this part of code, not zero.

Uncheck the brightness will set m_defaultValue to -1 so no function is lost.


This addresses bug 306925.
    http://bugs.kde.org/show_bug.cgi?id=306925


Diffs (updated)
-----

  powerdevil/daemon/actions/bundled/brightnesscontrol.cpp 5088e4e 

Diff: http://git.reviewboard.kde.org/r/108230/diff/


Testing
-------

now zero in profile works.


Thanks,

Xuetian Weng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130106/e0b789c8/attachment.htm>


More information about the kde-core-devel mailing list