Review Request: Fix KSelectionWatcher / KWindowSystem::compositingChanged signal

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107983/#review24639
-----------------------------------------------------------


Oh! A man who understands KSelectionWatcher! I need your help. Could you look into KSelectionWatcher in the kdelibs-frameworks branch (with Qt5 installed), and port the kselectionwatcher unittest to the new kselectionwatcher API (fredrikh made it async, due to XCB being async, but didn't port the unittest)?

- David Faure


On Dec. 30, 2012, 4:45 p.m., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107983/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2012, 4:45 p.m.)
> 
> 
> Review request for kdelibs, kwin, Aaron J. Seigo, Marco Martin, Martin Gräßlin, and Luboš Luňák.
> 
> 
> Description
> -------
> 
> It works fine here (tested so far KWindowSystem signal, KSelectionWatcher only with kwin) with kwin (shift+alt+f12), xcompmgr, compiz & "metacity -c" and e17.
> Didn't try xfce nor mutter.
> 
> Technically:
> I do not at all understand why KWindowSystem is *not* watching the root window - KSelectionOwner for one is sending events to the root and this also seems the case for all other WMs (at least everything now starts to cause the signal to be emitted)
> 
> As for SubstructureNotify, well, the message is sent to the root window - but the iccm suggests to send by StructureNotify mask (http://tronche.com/gui/x/icccm/sec-2.html) bottom of the page. I just gave it a wild shot ("hey, what if we tell everyone") and it absolutely reproducibly enables notification of selectionwatcher constructed before the eventloop is up (while it also very much seems to be not required once the eventloop is actually up) and i don't think it should hurt at all (but might hint a problem in rather the selectionwatcher, since we cannot expect others to send by that mask)
> 
> 
> This addresses bug 179042.
>     http://bugs.kde.org/show_bug.cgi?id=179042
> 
> 
> Diffs
> -----
> 
>   kdeui/util/kmanagerselection.cpp a289f47 
>   kdeui/windowmanagement/kwindowsystem_x11.cpp f9b3cc1 
> 
> Diff: http://git.reviewboard.kde.org/r/107983/diff/
> 
> 
> Testing
> -------
> 
> see summary
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130104/42af69a4/attachment.htm>