Review Request: Don't add qml elements twice to the scene, reduce warnings

Aleix Pol Gonzalez aleixpol at gmail.com
Wed Jan 2 14:20:41 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108079/
-----------------------------------------------------------

Review request for kdelibs, Plasma and Marco Martin.


Description
-------

don't addItem to the scene after calling setParentItem. It's redundant according to the api documentation and removes a warning.


Diffs
-----

  plasma/widgets/declarativewidget.cpp 81f09c3 

Diff: http://git.reviewboard.kde.org/r/108079/diff/


Testing
-------

Ran some plasmoids, works fine.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130102/254ba728/attachment.htm>
-------------- next part --------------
_______________________________________________
Plasma-devel mailing list
Plasma-devel at kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


More information about the kde-core-devel mailing list