Review Request 109196: Change PowerDevil module names and help links to make the KHC items meaningful

Sebastian Kügler sebas at kde.org
Thu Feb 28 13:02:31 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109196/#review28255
-----------------------------------------------------------


The names are getting too long this way, and will not look good in the KCM. That is their primary usecase, and there it is clear they they belong in the Power Management category.

I'm fine with changing the links to their specific anchors, though.

- Sebastian Kügler


On Feb. 27, 2013, 5:36 p.m., Yuri Chornoivan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109196/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2013, 5:36 p.m.)
> 
> 
> Review request for kde-workspace and Dario Freddi.
> 
> 
> Description
> -------
> 
> Current names of PowerDevil KCM modules are confusing when it comes to displaying help in KHelpCenter (see the bug report).
> 
> This patch tries to solve this problem.
> 
> 
> This addresses bug 315669.
>     http://bugs.kde.org/show_bug.cgi?id=315669
> 
> 
> Diffs
> -----
> 
>   powerdevil/kcmodule/global/powerdevilglobalconfig.desktop 0b27a10 
>   powerdevil/kcmodule/activities/powerdevilactivitiesconfig.desktop 00c0894 
> 
> Diff: http://git.reviewboard.kde.org/r/109196/diff/
> 
> 
> Testing
> -------
> 
> The new addresses for the help pages work as expected. The new names seems to be reasonable.
> 
> 
> Thanks,
> 
> Yuri Chornoivan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130228/9d9a1703/attachment.htm>


More information about the kde-core-devel mailing list