Review Request 109049: Fix favicon support for chrome bookmarks on krunner

[Marco Gulino]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109049/
-----------------------------------------------------------

(Updated Feb. 21, 2013, 7:29 p.m.)


Review request for kde-workspace and Plasma.


Description
-------

As reported by an user ( https://bugs.kde.org/show_bug.cgi?id=305633 ), chrome bookmarks database changed, and favicon wasn't shown anymore (not either the default "star" icon).
I added the functionality back, and added a safety guard for displaying the default icon if something similar happens again.
(note: I didn't set the "bugs" field here, since that bug was already closed, and was about something else).


Diffs (updated)
-----

  plasma/generic/runners/bookmarks/faviconfromblob.h cff4835 
  plasma/generic/runners/bookmarks/faviconfromblob.cpp 93c720c 
  plasma/generic/runners/bookmarks/fetchsqlite.h 8b181df 
  plasma/generic/runners/bookmarks/fetchsqlite.cpp 871deff 

Diff: http://git.reviewboard.kde.org/r/109049/diff/


Testing
-------

with chrome as default browser, install the plugin, restart krunner, type "bookmarks" to view all bookmarks: proper favicon is shown.
Removing the database query fix, but leaving the safety guard, and cleaning favicon cache (to have again a "broken" feature case), the default icon is shown.


Thanks,

Marco Gulino

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130221/707c6883/attachment.htm>