Review Request 109049: Fix favicon support for chrome bookmarks on krunner

[Àlex Fiestas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109049/#review27760
-----------------------------------------------------------


I guess this will break compatibility with old versions then? if so, do you know from which version will it work?
If this was not long ago, can we check the version and keep supporting the old and the new one?

- Àlex Fiestas


On Feb. 19, 2013, 10:42 p.m., Marco Gulino wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109049/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2013, 10:42 p.m.)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Description
> -------
> 
> As reported by an user ( https://bugs.kde.org/show_bug.cgi?id=305633 ), chrome bookmarks database changed, and favicon wasn't shown anymore (not either the default "star" icon).
> I added the functionality back, and added a safety guard for displaying the default icon if something similar happens again.
> (note: I didn't set the "bugs" field here, since that bug was already closed, and was about something else).
> 
> 
> Diffs
> -----
> 
>   plasma/generic/runners/bookmarks/faviconfromblob.cpp 93c720c 
> 
> Diff: http://git.reviewboard.kde.org/r/109049/diff/
> 
> 
> Testing
> -------
> 
> with chrome as default browser, install the plugin, restart krunner, type "bookmarks" to view all bookmarks: proper favicon is shown.
> Removing the database query fix, but leaving the safety guard, and cleaning favicon cache (to have again a "broken" feature case), the default icon is shown.
> 
> 
> Thanks,
> 
> Marco Gulino
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130220/9374b63e/attachment.htm>