Review Request 108983: Konqueror does not navigate to the entered URL if completion mode is turned off

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108983/#review27563
-----------------------------------------------------------


This review has been submitted with commit 1cdbf2e53f1991bd55c09310079f238ea90ee802 by Dawit Alemayehu to branch KDE/4.10.

- Commit Hook


On Feb. 16, 2013, 4:30 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108983/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2013, 4:30 p.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Description
> -------
> 
> Connect to the returnPressed signal when the completionMode in KonqCombo is set to CompletionNone. Otherwise, pressing return or clicking the Go button has no effect.
> 
> 
> This addresses bug 314736.
>     http://bugs.kde.org/show_bug.cgi?id=314736
> 
> 
> Diffs
> -----
> 
>   konqueror/src/konqcombo.h 9d19bb3 
>   konqueror/src/konqcombo.cpp 598de11 
> 
> Diff: http://git.reviewboard.kde.org/r/108983/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130217/e3056fcb/attachment.htm>