Review Request 108929: khtml/kjs: Implement typed-arrays

[Rolf Eike Beer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108929/#review27549
-----------------------------------------------------------



khtml/ecma/kjs_arraybuffer.cpp
<http://git.reviewboard.kde.org/r/108929/#comment20674>

    Those can be size_t, you check that the passed value is > 0 before assignment anyway.



khtml/ecma/kjs_arraybuffer.cpp
<http://git.reviewboard.kde.org/r/108929/#comment20675>

    This doesn't need to be ssize_t either, you also check for is being always positive. This allows to get rid of the cast in the second if.



khtml/ecma/kjs_arraybufferview.h
<http://git.reviewboard.kde.org/r/108929/#comment20676>

    Can be size_t, for the same reason as above.



khtml/ecma/kjs_arraybufferview.h
<http://git.reviewboard.kde.org/r/108929/#comment20677>

    should be static_cast<size_t>, the result is of type size_t.



khtml/ecma/kjs_arraybufferview.h
<http://git.reviewboard.kde.org/r/108929/#comment20678>

    Is it guaranteed that this doesn't wraparound? That would be one of the few cases where ssize_t may actually be needed.



khtml/ecma/kjs_arraybufferview.h
<http://git.reviewboard.kde.org/r/108929/#comment20679>

    size_t


- Rolf Eike Beer


On Feb. 13, 2013, 8:18 p.m., Bernd Buschinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108929/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2013, 8:18 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> khtml/kjs: Implement typed-arrays
> 
> ArrayBuffer, Int8Array, Uint8Array, Int16Array, Uint16Array, Int32Array, Uint32Array, Float32Array, Float64Array
> 
> I tested many configuration under valgrind, to find all possible errors.
> It seems other browsers don't set a limit, so you can eat all memory with these arrays (danger), so khtml/kjs also doesn't set a limit. If you feel like we really need one, please tell.
> 
> 
> Diffs
> -----
> 
>   khtml/CMakeLists.txt 99034cc 
>   khtml/ecma/kjs_arraybuffer.h PRE-CREATION 
>   khtml/ecma/kjs_arraybuffer.cpp PRE-CREATION 
>   khtml/ecma/kjs_arraybufferview.h PRE-CREATION 
>   khtml/ecma/kjs_arraybufferview.cpp PRE-CREATION 
>   khtml/ecma/kjs_window.h 1b70be1 
>   khtml/ecma/kjs_window.cpp 927d251 
> 
> Diff: http://git.reviewboard.kde.org/r/108929/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130216/44b42e2e/attachment.htm>