Review Request 108808: Do not reset opacity if call for GetWindowProperty fails

[Aurélien Gâteau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108808/#review26756
-----------------------------------------------------------


Works fine here.

- Aurélien Gâteau


On Feb. 6, 2013, 3:38 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108808/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2013, 3:38 p.m.)
> 
> 
> Review request for kdelibs and kwin.
> 
> 
> Description
> -------
> 
> Do not reset opacity if call for GetWindowProperty fails
> 
> The opacity got unconditionally reset to the default value of fully
> opaque. In case the property has a value of 0 and the call to get the
> window property fails, the window would be shown again. This issue was
> spotted with colibri which faded out it's window and got a flash to
> fully opaque again.
> 
> I'm sorry that it's difficult to read this patch properly due to the
> existing mixing of tabs and whitespaces. The patch changes two things:
> * only updates the value if all checks succeed
> * initialise the data_ret variable to not cause a crash on free
> 
> BUG: 314427
> FIXED-IN: 4.10.1
> 
> 
> Diffs
> -----
> 
>   kdeui/windowmanagement/netwm.cpp cf28339f90dff1d17ed17842c7c11d8a9718a459 
> 
> Diff: http://git.reviewboard.kde.org/r/108808/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130206/07423274/attachment.htm>