Review Request 108731: khtml/canvas: Use extra bool to check if PainterPath is empty

[Bernd Buschinski]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108731/
-----------------------------------------------------------

(Updated Feb. 4, 2013, 12:02 a.m.)


Review request for kdelibs.


Changes
-------

Don't mark Path as empty on closeSubpath call.
Qt doc confussed me, but it does the right thing.


Description
-------

khtml/canvas: Use extra bool to check if PainterPath is empty,
storring a Inf/Inf member no longer work with recent Qt versions and
storring NaN/NaN never worked, Qt just ignores storring them.

And set Starting point in arcTo if Path is empty, according to:
http://philip.html5.org/tests/canvas/suite/tests/spec.html#testrefs.2d.path.arcTo.empty
http://philip.html5.org/tests/canvas/suite/tests/spec.html#ensure-there-is-a-subpath
and test:
http://philip.html5.org/tests/canvas/suite/tests/2d.path.arcTo.ensuresubpath.1.html


Diffs (updated)
-----

  khtml/html/html_canvasimpl.h f31954f 
  khtml/html/html_canvasimpl.cpp 93d5db7 

Diff: http://git.reviewboard.kde.org/r/108731/diff/


Testing
-------


Thanks,

Bernd Buschinski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130204/86402e06/attachment.htm>