Review Request 108675: kjs: Implement Function.prototype.bind
Bernd Buschinski
b.buschinski at googlemail.com
Fri Feb 1 00:29:01 GMT 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108675/
-----------------------------------------------------------
(Updated Feb. 1, 2013, 12:29 a.m.)
Review request for kdelibs.
Changes
-------
Protect the pointers and use callAsFunction instead of call, because callAsFunction is virtual
Description
-------
kjs: Implement Function.prototype.bind
following ECMAScript Edition 5.1r6 15.3.4.5
The only tiny difference is that the "thisArg" can not be null or undefined.
As we call use null or undefined as thisObject in call.
So, like in Function.prototype.call, I use the global object instead.
NOTE: this patch also depends on Object.defineOwnProperty
Diffs (updated)
-----
kjs/function.h 5dbbfb2
kjs/function.cpp 6263b36
kjs/function_object.h ebcb937
kjs/function_object.cpp 76f55cb
Diff: http://git.reviewboard.kde.org/r/108675/diff/
Testing
-------
passes all Function.prototype.bind ecmascript testcases and does not introduce regressions.
Thanks,
Bernd Buschinski
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130201/c6e9f695/attachment.htm>
More information about the kde-core-devel
mailing list