Review Request 114479: Select the newly created bookmark folder as the current item

Dawit Alemayehu adawit at kde.org
Tue Dec 24 06:00:53 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114479/
-----------------------------------------------------------

(Updated Dec. 24, 2013, 6 a.m.)


Review request for kdelibs and David Faure.


Changes
-------

Overloaded the fillGroup function to allow the current item to be selected.


Bugs: 152158
    http://bugs.kde.org/show_bug.cgi?id=152158


Repository: kdelibs


Description
-------

When a user creates a new bookmark folder in the Add Bookmark dialog, make it the current selected item.


Diffs (updated)
-----

  kio/bookmarks/kbookmarkdialog.h a746c22 
  kio/bookmarks/kbookmarkdialog.cc 713ceff 

Diff: https://git.reviewboard.kde.org/r/114479/diff/


Testing
-------


File Attachments
----------------

Add new folder w/o patch
  https://git.reviewboard.kde.org/media/uploaded/files/2013/12/15/1be1b4c9-eddd-43cf-b3fa-18cc0a44b212__before.png
Add new folder w/ patch
  https://git.reviewboard.kde.org/media/uploaded/files/2013/12/15/353b3c50-ccc8-4390-9d76-a9f85a703987__after.png


Thanks,

Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131224/ce1079d4/attachment.htm>


More information about the kde-core-devel mailing list