Review Request 114455: kjs: Implement ES6 Math.imul

Bernd Buschinski b.buschinski at
Sun Dec 22 19:34:42 GMT 2013

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 22, 2013, 7:34 p.m.)

Review request for kdelibs.


- make imul behave like the original c/asm imul

This makes the most sense to me, and is what webkit does too.

Repository: kdelibs


kjs: Implement ES6 Math.imul

I admit I am totally lost here, I need help, the specs just confuse me. The code doesn't look like it does anything useful.

step 1 to 4 is just getting the values.
a and b must be a uint32_t.

5. Let product be (a * b) modulo 2^32.
6. If product ? 2^31, return product - 2^32, otherwise return product.

(Taken from ES6 draft 08.11.2013)

This is the part I don't understand at all.
I am not even sure about the product datatype.

Also NOTE: the JSC and firefox implementation look totally different and both return different values in highvalue cases, so I rather not trust them.

Diffs (updated)

  kjs/math_object.h 3d193dd 
  kjs/math_object.cpp 89835e5 




Bernd Buschinski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list