Review Request 114519: fix endless loop in KLineEdit->setSqueezedText()

Axel Arnold arnolda747 at gmail.com
Tue Dec 17 15:15:17 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114519/
-----------------------------------------------------------

Review request for kdelibs.


Bugs: 328263
    http://bugs.kde.org/show_bug.cgi?id=328263


Repository: kdelibs


Description
-------

If KLineEdit has squeezed text enabled, but the widget has still zero width, KLineEdit::setSqueezedText() can go into an endless loop trying to remove more than all letters from the string. This patch fixes both this underrun and the corresponding possible overrun if the squeezed text is too small. The underrun is responsible for endless loops in digikam, see the corresponding bug report.


Diffs
-----

  kdeui/widgets/klineedit.cpp 2193ef2969d49ad602e66da7776feda4b7595b13 

Diff: http://git.reviewboard.kde.org/r/114519/diff/


Testing
-------


Thanks,

Axel Arnold

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131217/ddad16e3/attachment.htm>


More information about the kde-core-devel mailing list