Review Request 114472: kjs: Implement ES6 Number parseInt, parseFloat

Martin Tobias Holmedahl Sandsmark martin.sandsmark at kde.org
Tue Dec 17 11:36:33 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114472/#review45855
-----------------------------------------------------------

Ship it!


Ship It!

- Martin Tobias Holmedahl Sandsmark


On Dec. 15, 2013, 10:07 a.m., Bernd Buschinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114472/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2013, 10:07 a.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> kjs: Implement ES6 Number parseInt, parseFloat
> 
> NOTE: unlike the other new ES6 Number function these two MUST behave the same as the global parseInt/parseFloat.
> The explicit number type check is only valid for the other functions, not for parseInt/parseFloat and therefor was moved to the functions.
> 
> 
> Diffs
> -----
> 
>   kjs/function.h 17958ab 
>   kjs/function.cpp 1102208 
>   kjs/number_object.h 634c642 
>   kjs/number_object.cpp c284746 
> 
> Diff: http://git.reviewboard.kde.org/r/114472/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131217/477dd9a6/attachment.htm>


More information about the kde-core-devel mailing list