Review Request 114506: Create testcase for bookmark toolbar

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114506/#review45845
-----------------------------------------------------------


I'd say that adding unit tests never hurts :-) I can't really comment on the XML stuff though because I'm not familiar with the format in which the bookmarks are stored.

- Frank Reininghaus


On Dec. 16, 2013, 6:44 p.m., Stefan Brüns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114506/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2013, 6:44 p.m.)
> 
> 
> Review request for kdelibs and Frank Reininghaus.
> 
> 
> Bugs: 320006
>     http://bugs.kde.org/show_bug.cgi?id=320006
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Tried to reproduce 320006, even inserting bogus content into the bookmarks does not trigger any crashes for me. Providing the testcase anyway ...
> 
> 
> Diffs
> -----
> 
>   kio/tests/kbookmarktest.h 14121ac 
>   kio/tests/kbookmarktest.cpp 5ab002b 
> 
> Diff: http://git.reviewboard.kde.org/r/114506/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Stefan Brüns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131217/b96f8793/attachment.htm>