Review Request 113866: kio bookmarks: Only iterate over element nodes in findToolbar()

[Stefan Brüns]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113866/
-----------------------------------------------------------

(Updated Dec. 16, 2013, 6:33 p.m.)


Review request for kdelibs and Frank Reininghaus.


Changes
-------

changed QDomNode to QDomElement in for loop


Bugs: 320006
    http://bugs.kde.org/show_bug.cgi?id=320006


Repository: kdelibs


Description
-------

Only iterate over element nodes, and filter on <folder> tag.

findFirstChild/nextSibling might return a node which is not an QDomElement. toElement will return NULL and accessing it will crash.

Possible fix for 320006


Diffs (updated)
-----

  kio/bookmarks/kbookmark.cc 8459a02 

Diff: http://git.reviewboard.kde.org/r/113866/diff/


Testing
-------

None


Thanks,

Stefan Brüns

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131216/296ed5a7/attachment.htm>