Review Request 114454: kjs: Implement ES6 Math.hypot

[Bernd Buschinski]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114454/
-----------------------------------------------------------

(Updated Dec. 14, 2013, 6:53 p.m.)


Review request for kdelibs.


Changes
-------

- changed to 1 single loop


Repository: kdelibs


Description
-------

kjs: Implement ES6 Math.hypot

I agree that the loop, that is just checking for Inf looks weird, but thats what the spec says.
We MUST check everything first for Inf, NaN checks must come later.

So a (1, NaN, Inf) must return Inf.


Diffs (updated)
-----

  kjs/math_object.h 3d193dd 
  kjs/math_object.cpp 89835e5 

Diff: http://git.reviewboard.kde.org/r/114454/diff/


Testing
-------


Thanks,

Bernd Buschinski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131214/053d282f/attachment.htm>