Review Request 113360: PolkitActionsKCM: Use a simple pointer for m_actionWidget.

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113360/#review45497
-----------------------------------------------------------


This review has been submitted with commit dbfa291938b1990b01c13c0dcf2fc378bca2a10d by Ivan Shapovalov to branch master.

- Commit Hook


On Dec. 8, 2013, 10:45 a.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113360/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2013, 10:45 a.m.)
> 
> 
> Review request for kde-workspace, Polkit KDE Configuration and Dario Freddi.
> 
> 
> Repository: polkit-kde-kcmodules-1
> 
> 
> Description
> -------
> 
> QPointer<> crashes for me (Arch), the crash is non-debuggable (only in Release mode) and I do not see a way how can m_actionWidget suddenly disappear.
> 
> 
> Diffs
> -----
> 
>   polkitactions/PolkitActionsKCM.h 84c6581 
>   polkitactions/PolkitActionsKCM.cpp a88bf65 
> 
> Diff: http://git.reviewboard.kde.org/r/113360/diff/
> 
> 
> Testing
> -------
> 
> - Ensured that it fixes the crash for me
> - Made some test modifications and ensured that it does not crash in other places
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131210/b9498fe3/attachment.htm>