Review Request 114368: Fix freeze of plasma-desktop after resume using smb/nfs mounts in /etc/mtab.

[Thomas Lübking]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114368/#review45425
-----------------------------------------------------------


Errr.... wouldn't that completely change the behavior?

If i so far had a file in /mnt and a symlink to it in /home, KMountPoint::List::findByPath(/home/me/symlink) would have told me the file is in /mnt - now it will tell me it's on /home, what's wrong and i might false positively "safely" umount /mnt or whatever.

Also I wonder whether result will ever remain 0 (or you just effectively scratched KStandardDirs::realFilePath(path) completely)

And have you tested dumping in the behavior of the pathsAreParentAndChildOrEqual() local static?
Can it correctly handle non canonical paths ("../foo/../bar///.././foo/bar") at all?


I'd rather say that for a fix, GUIs should thread off KMountPoint resolution (as any I/O op...) or the function needs a nested eventloop (ewww...)

- Thomas Lübking


On Dec. 9, 2013, 5:16 p.m., Ralf Habacker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114368/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2013, 5:16 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Bugs: 184062
>     http://bugs.kde.org/show_bug.cgi?id=184062
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> KMountPoint::List::findByPath() calls realpath for each given path.
> When using NetworkManager controlled connections on resume these calls
> are blocked, because the connection is not ready at this state.
> The function returns from the blocking state after a very long timeout (several minutes) . 
>     
> This patch avoids blocking realpath calls for pathes directly located in
> /etc/mtab. As far as I can see there is no need to call realpath for this cases.
> 
> 
> Diffs
> -----
> 
>   kdecore/io/kmountpoint.cpp d06d796 
> 
> Diff: http://git.reviewboard.kde.org/r/114368/diff/
> 
> 
> Testing
> -------
> 
> opensuse 12.2 x86_64, KDE 4.11.2
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131209/885e752d/attachment.htm>