Review Request 113360: PolkitActionsKCM: Use a simple pointer for m_actionWidget.

[Ivan Shapovalov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113360/
-----------------------------------------------------------

(Updated Dec. 8, 2013, 10:45 a.m.)


Review request for kde-workspace, Polkit KDE Configuration and Dario Freddi.


Changes
-------

Added Dario Freddi to reviewer list.


Repository: polkit-kde-kcmodules-1


Description
-------

QPointer<> crashes for me (Arch), the crash is non-debuggable (only in Release mode) and I do not see a way how can m_actionWidget suddenly disappear.


Diffs
-----

  polkitactions/PolkitActionsKCM.h 84c6581 
  polkitactions/PolkitActionsKCM.cpp a88bf65 

Diff: http://git.reviewboard.kde.org/r/113360/diff/


Testing
-------

- Ensured that it fixes the crash for me
- Made some test modifications and ensured that it does not crash in other places


Thanks,

Ivan Shapovalov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131208/69ee59d6/attachment.htm>