Review Request 114321: Fix timezone saving in System Settings -> Date & Time

[Lukáš Tinkl]

> On Dec. 6, 2013, 1:22 a.m., Thomas Lübking wrote:
> > kcontrol/dateandtime/helper.cpp, line 180
> > <http://git.reviewboard.kde.org/r/114321/diff/1/?file=222931#file222931line180>
> >
> >     What's the problem about using zic?
> >     If zic is broken (distro related?) zic should be fixed, yesno?

This step is not needed at all


> On Dec. 6, 2013, 1:22 a.m., Thomas Lübking wrote:
> > kcontrol/dateandtime/helper.cpp, line 189
> > <http://git.reviewboard.kde.org/r/114321/diff/1/?file=222931#file222931line189>
> >
> >     assuming zic is not available and the fallback is required, this should maybe inspect the type of the present localtime (if) and link/copy the new timezone respectively?

No issue, the /etc/timezone handling is still there, a few lines below


> On Dec. 6, 2013, 1:22 a.m., Thomas Lübking wrote:
> > kcontrol/dateandtime/helper.cpp, line 204
> > <http://git.reviewboard.kde.org/r/114321/diff/1/?file=222931#file222931line204>
> >
> >     this looks like it'll break compilation on solaris?

I don't think so, previously the code was wrong:

QString val = ':' + tz;
#endif // !USE_SOLARIS
setenv("TZ", val.toAscii(), 1);

so it would be setting the TZ from an uninit value on Solaris, I don't know how this could ever compile


> On Dec. 6, 2013, 1:22 a.m., Thomas Lübking wrote:
> > kcontrol/dateandtime/helper.cpp, line 206
> > <http://git.reviewboard.kde.org/r/114321/diff/1/?file=222931#file222931line206>
> >
> >     iff ASCII is wrong, this should be rather ::toLocal8Bit(), yesno?

Hmm, maybe, but I think utf8 is safer here


- Lukáš


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114321/#review45241
-----------------------------------------------------------


On Dec. 6, 2013, 12:24 a.m., Lukáš Tinkl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114321/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2013, 12:24 a.m.)
> 
> 
> Review request for kde-workspace.
> 
> 
> Bugs: 159171 and 323511
>     http://bugs.kde.org/show_bug.cgi?id=159171
>     http://bugs.kde.org/show_bug.cgi?id=323511
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> - fix saving/loading of timezones in kcmclock
> - do not mark the module as changed right after the new timezone gets loaded back
> 
> Besides the above mentioned bugs, it also fixes https://bugzilla.redhat.com/show_bug.cgi?id=990146
> 
> 
> Diffs
> -----
> 
>   kcontrol/dateandtime/dtime.cpp 518afe5 
>   kcontrol/dateandtime/helper.cpp 9168db3 
>   kcontrol/dateandtime/main.cpp 2fa0f3e 
> 
> Diff: http://git.reviewboard.kde.org/r/114321/diff/
> 
> 
> Testing
> -------
> 
> In the past, this would for some reason only work sporadically and make ktimezoned utterly confused; now it correctly sets a symlink (instead of copying the file over) from /etc/localtime to the respective file under /usr/share/zoneinfo (as described in "man tzset"). The symlink points to the right location after each save. Launching the module again, it shows the correct timezone, as previously saved. 
> 
> 
> Thanks,
> 
> Lukáš Tinkl
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131206/81229086/attachment.htm>