Review Request 114321: Fix timezone saving in System Settings -> Date & Time

[Lukáš Tinkl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114321/
-----------------------------------------------------------

Review request for kde-workspace.


Bugs: 159171 and 323511
    http://bugs.kde.org/show_bug.cgi?id=159171
    http://bugs.kde.org/show_bug.cgi?id=323511


Repository: kde-workspace


Description
-------

- fix saving/loading of timezones in kcmclock
- do not mark the module as changed right after the new timezone gets loaded back

Besides the above mentioned bugs, it also fixes https://bugzilla.redhat.com/show_bug.cgi?id=990146


Diffs
-----

  kcontrol/dateandtime/dtime.cpp 518afe5 
  kcontrol/dateandtime/helper.cpp 9168db3 
  kcontrol/dateandtime/main.cpp 2fa0f3e 

Diff: http://git.reviewboard.kde.org/r/114321/diff/


Testing
-------

In the past, this would for some reason only work sporadically and make ktimezoned utterly confused; now it correctly sets a symlink (instead of copying the file over) from /etc/localtime to the respective file under /usr/share/zoneinfo (as described in "man tzset"). The symlink points to the right location after each save. Launching the module again, it shows the correct timezone, as previously saved. 


Thanks,

Lukáš Tinkl

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131205/07f4443e/attachment.htm>