Review Request 114298: prevent ksplashqml crash when a theme does not exist or cannot be loaded

[Harald Sitter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114298/
-----------------------------------------------------------

(Updated Dec. 5, 2013, 10:14 a.m.)


Status
------

This change has been marked as submitted.


Review request for kde-workspace and Ivan Čukić.


Repository: kde-workspace


Description
-------

Do not crash when failing to load a theme, but instead exit.

When failing to load the theme's qml file QDeclarativeView goes into error
state, at which point we want to exit to prevent nullptr access problems.


Diffs
-----

  ksplash/ksplashqml/SplashApp.cpp 7c528d056ee680f69a6d3d60d1dbeeae9d548846 

Diff: http://git.reviewboard.kde.org/r/114298/diff/


Testing
-------

ksplashqml Foo --test

-> sigsev without patch
-> exits with patch


Thanks,

Harald Sitter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131205/7e690331/attachment.htm>