Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

Andrius da Costa Ribas andriusmao-Re5JQEeQqe8AvxtiuMwx3w at
Sun Dec 1 02:17:36 GMT 2013

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 1, 2013, 2:17 a.m.)


This change has been marked as submitted.

Review request for KDE Runtime, kdewin and Pali Rohár.

Repository: kde-runtime


This patch intends to enable Windows exe/dll thumbnailing by using winapi. It derives from the unsubmitted patch from Pali Rohár from as a starting point. I've made a few adjustments on the original patch, split that patch into a common part and a icoutils-specific part, and then created the winapi-based part to replace the icoutils one on Windows (porting icoutils to windows wasn't going to be easy).


  kioslave/thumbnail/CMakeLists.txt b81339b 
  kioslave/thumbnail/icoutils.h 6468bc1 
  kioslave/thumbnail/icoutils.cpp 31db85d 
  kioslave/thumbnail/icoutils_common.cpp PRE-CREATION 
  kioslave/thumbnail/icoutils_win.cpp PRE-CREATION 
  kioslave/thumbnail/icoutils_wrestool.cpp PRE-CREATION 
  kioslave/thumbnail/windowsexecreator.h a407982 
  kioslave/thumbnail/windowsexecreator.cpp 9e24aee 
  kioslave/thumbnail/windowsexethumbnail.desktop f10efef 
  kioslave/thumbnail/windowsimagecreator.h 0b68cc6 
  kioslave/thumbnail/windowsimagecreator.cpp 08b063d 



Tested on a Windows 7 64-bit machine, with intel compiler (32-bit).
Tested using ico files and both 32-bit and 64-bit executables and dlls, including jumbo-size icons.
I've used QLibrary for all winapi functions in order to avoid issues with MinGW compiler, but I don't have a MinGW setup to check.

Not tested on *nix, but the original patch was not changed except for iterating order in the common part and namespacing.

File Attachments



Andrius da Costa Ribas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>
-------------- next part --------------
Kde-windows mailing list
Kde-windows-RoXCvvDuEio at

More information about the kde-core-devel mailing list